Skip to content
GitLab

Fix missing modifications when `--bs-{color}-text` was changed to `--bs-{color}-text-emphasis`

Merged Julien Déramond requested to merge main-jd-fix-missing-modification-for-text-emphasis into main

Description

https://github.com/twbs/bootstrap/commit/15744ee1d04bcca03155c3bb37ee7e65a7b011c6 introduced the following change: bs-{color}-text → bs-{color}-text-emphasis

This PR fixes some missing modifications in:

  • scss/tests/mixins/_color-modes.test.scss
  • scss/_variables.scss that fixes the rendering of the active text color in both light and dark modes

Please double-check that we haven't forgotten other things with different combinations of --bs-{color}-text and/or --#{$prefix}{color}-text.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (N/A) My change introduces changes to the documentation
  • (N/A) I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews