Skip to content
GitLab

Deprecate the `remote` option of modals?

Merged Administrator requested to merge deprecate-modal-remote into master

Created by: cvrebert

  • @fat closed #13788 (which would have added the completely-reasonable ability to disable unwanted caching for remote)
  • remote doesn't currently give any "loading..." (or similar) visual indication while the network request is in-progress, and doesn't fire any "loading started" event
  • remote doesn't currently give any visual indication or fire any event when the network request fails
  • Depending on the use-case, the user may want to either reuse or refresh the modal's header/footer. In older versions, the user had no nice way of reloading the header. In newer versions, users who don't want to modify the header must regenerate it on their backend anyway. (See #13597)
  • The existence of remote can discourage the use of client-side templating, even when it might be a preferable option.

So, I think we have 3 options:

  1. Add several features to remote modals.
  2. (This PR.) Deprecate remote modals.
  3. Status quo: Intentionally leave remote modals in a somewhat half-assed state.

CC: @fat @twbs/team for discussion