Skip to content
GitLab

Prevent dangerous query method on #order_by_id

Merged Administrator requested to merge github/fork/sejinkim1904/fix-deprecation-warning into master

Created by: sejinkim1904

What does this PR do?

  • Adds Arel.sql() to #order_by_id in /lib/order.rb to prevent deprecation warning for dangerous query method.
  • Adds test for sorting by has_many association

Where should the reviewer start?

/lib/order.rb

How should this be manually tested?

  • Temporarily remove Arel.sql() from #order_by_id
  • Run bundle exec appraisal rails52 rspec spec/features/index_page_spec.rb

What are the relevant tickets?

#1758

Questions:

  • Do Migrations Need to be ran? NO
  • Do Environment Variables need to be set? NO
  • Any other deploy steps? NO