Skip to content
GitLab

Move ESLint cache file into node_modules

Merged Administrator requested to merge github/fork/ehsankhfr/eslint-cache-file into master

Created by: ehsankhfr

Fix #9970 (closed) Fix #10161 (closed)

As mentioned in https://github.com/facebook/create-react-app/pull/9977#discussion_r515618643, likewise eslint-loader, we need to support non-existing OR inaccessible path fallback for cache folder into os.tempdir, as current(new) eslint plugin doesn't support the fallback.

TEST PLAN:

To test how permission issue folder fallback works:

  1. under the node_module
    • Remove the .cache folder content, if folder exists.
    • Or, create .cache folder
  2. run chmod u=r--,g=r--,o=r-- node_modules/.cache
  3. run npm start
  4. ls node_modules/.cache should not show the .eslintcache file

To test how non-existent folder fallback works:

  1. under the node_module
    • Remove the .cache folder content, if folder exists
  2. run npm start
  3. ls node_modules/.cache should not show the .eslintcache file

To test how normal flow of caching works:

  1. under the node_module
    1. Make sure the .cache folder exists
    2. Make sure there is enough access to the folder .cache: chmod u=rwx,g=r-x,o=r-x node_modules/.cache
  2. run npm start
  3. ls node_modules/.cache should show the .eslintcache file