Skip to content
GitLab

fix: page doesn't get refreshed when FAST_REFRESH=false

Merged Administrator requested to merge github/fork/n3tr/fix-non-fast-refresh-reload into master

Created by: n3tr

Page doesn't get refreshed when disabling FAST_REFRESH. This is because the process.env.FAST_REFRESH in webpackHotDevClient is a boolean value, comparing !== 'false' will always return true.

Verify steps

  • yarn create-react-app my-app
  • yarn start
  • Modify App.js content
  • The app gets updated through Fast Refresh

FAST_REFRESH=false

  • Start the app by using FAST_REFRESH=false yarn start
  • Modify App.js
  • The app should do a full reload