Skip to content
GitLab

Remove `Object.assign` from `MiniCssExtractPlugin` options

Merged Administrator requested to merge github/fork/swashcap/fix-remove-unneeded-object-assign into master

Created by: swashcap

👋 Hello! I'm reading through react-scripts' Webpack configuration to learn a little bit more about Webpack. Thanks for the ample comments! It's super helpful.

I noticed this unneeded Object.assign in a .css loader's options, so thought I'd remove it.

  • Problem: Using Object.assign in shouldUseRelativeAssetPaths falsey case adds a lil bit of an unneeded function call
  • Solution: Remove Object.assign and add {} to the ternary false expression
  • Testing: ?