Skip to content
GitLab

ESLint 4

Merged Administrator requested to merge github/fork/trungdq88/master into master

Created by: trungdq88

Changes

  • Upgrades eslint-loader from 1.7.1 -> 1.9.0.
  • Add eslintPath option to eslint-loader
  • Upgrades ESLint from 3.19.0 to 4.1.1
  • Upgrades the unmet dependencies of ESlint 4.1.1.

Resolve related issues: https://github.com/facebookincubator/create-react-app/issues/2528, https://github.com/facebookincubator/create-react-app/issues/2604, https://github.com/facebookincubator/create-react-app/issues/2631

Tested with issue https://github.com/facebookincubator/create-react-app/issues/2528, verify with following script:

npm run create-react-app verify-issue-2528
cd verify-issue-2528
yarn add eslint
vim src/App.js # Add prop types to App.js

#  static propTypes = {
#    aoeu: React.PropTypes.any,
#  }

yarn run build # Should build success :tada:

Screenshot

image

Tests

Passed: https://travis-ci.org/trungdq88/create-react-app/builds/250878659