Skip to content
GitLab

Convert react-error-overlay to React

Merged Administrator requested to merge github/fork/tharakawj/reactify-error-overlay into master

Created by: tharakawj

Proposed in #2100 (closed)

Some points to discuss,

  1. CodeBlock component still depends on old DOM manipulation code and dangerouslySetInnerHTML. Any suggestions to make it better?
  2. Used HTML button elements instead of clickable (tab clickable) divs with similar styling. Any downside of that?
  3. I'm not much sure about the purpose of consumeEvent.js. Can you think of a better alternative to get the same behavior with React?