Skip to content
GitLab

fix(react-scripts): disable custom TS PnP resolve for Yarn >= 2

Closed Administrator requested to merge github/fork/merceyz/merceyz/fix/json-resolve into main

Created by: merceyz

What's the problem this PR addresses?

Importing .json files causes TypeScript builds to fail with

TypeScript error in /path/to/project/src/App.tsx(4,18):
Cannot find module './foo.json' or its corresponding type declarations.  TS2307

Fixes https://github.com/facebook/create-react-app/issues/9172 Fixes https://github.com/facebook/create-react-app/issues/10455

How did you fix it?

Disabled the custom resolve provided to ForkTsCheckerWebpackPlugin when using Yarn >= 2. This fixes the issue since Yarn 2+ adds support for PnP directly to TypeScript which has access to the correct compilerOptions, the one passed to ts-pnp is an empty object.