Skip to content
GitLab

[Erlang] Return empty body for 304

Merged Administrator requested to merge github/fork/wmnsk/erlang-empty-body-304 into master

Created by: wmnsk

Similar to https://github.com/OpenAPITools/openapi-generator/pull/9512. This PR just adds 304 to the condition that should return an empty body to cowboy, as it has the same validation as 204: https://github.com/ninenines/cowboy/blob/2a082504996afccf78185182cd168123800bd4f0/src/cowboy_req.erl#L807-L824

@tsloughter (2017/11) @jfacorro (2018/10) @robertoaloi (2018/10)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.