Merged
requested to merge github/fork/chludwig-haufe/fix-python-fastapi-freeform-and-forward-ref into master
Created by: chludwig-haufe
This PR implements the proposed fixes for #9720 (closed) and #9721 (closed):
- Free-form object model attributes are mapped to the type hint
Dict[str, Any]. - To support forward type references in the type hints generated for (recursive) model classes, add
from __future__ import annotationsto the model template. (This is supported in Python >= 3.7.)
With these changes in place, the generated FastAPI service could actually be started.
Python technical committee: @taxpon, @frol, @mbohlool, @cbornet, @kenjones-cisco, @tomplus, @Jyhess, @arun-nalla, @spacether
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master,5.1.x,6.0.x -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.