Skip to content
GitLab

Fix loss of multiple header values for python api client

Closed Administrator requested to merge github/fork/jkupferer/jkupferer-use-HTTPHeaderDict into master

Created by: jkupferer

Fix Python library headers loss of multiple values by switching from dict to use of urllib3 HTTPHeaderDict. In particular this fix is needed for passing multiple values to Impersonate-Group header.

https://github.com/kubernetes-client/python/issues/1462 https://github.com/kubernetes-client/python/pull/1463

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess @arun-nalla @spacether