Skip to content
GitLab

[TypeScript - Angular] Syntax correction in the configuration.ts template

Open Administrator requested to merge github/fork/nnworkspace/patch-1 into master

Created by: nnworkspace

The generated configuration.ts contains error and warnings from my TypeScript 4.1.5 compiler. things like this.apiKeys['api_key'] is not allowed and I changed it to this.apiKeys?.api_key, and edited the Mustache template accordingly here.

Note: When the property name contains "-" sign, the dot syntax won't work. I had problem converting this.apiKeys['X-API-Key'] to this.apiKeys.X-API-Key. That's why I used ts-ignore once in the file.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.