Skip to content
GitLab

Support openApiNullable in jaxrs-cxf-client generator

Merged Administrator requested to merge github/fork/cowclaw/jaxrs_cxf_client_support_openapi_nullable into master

Created by: cowclaw

Until now the jaxrs-cxf-client generator does not support the openApiNullable config option although https://openapi-generator.tech/docs/generators/jaxrs-cxf-client lists is explicitly. Support for openApiNullable using jackson-databind-nullable (https://github.com/OpenAPITools/jackson-databind-nullable) is added in this PR.

Hints for the reviewer:

  • The PR is best reviewed commit-by-commit. The commits are written to be most reviewer-friendly.
  • The first commit introduces a new petstore sample for jaxrs-cxf-client with additional property jackson set to true. It reuses modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing.yaml which already provides many nullable properties.
  • The remainder of the PR subsequently adjusts the code generation. Each commit updates the mustache file and the generated code samples (by running the generator after adjusting the template).

cc: @wing328 @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @nmuesch

Thanks in advance!

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.