Created by: 4brunu
AbstractKotlinCodegen.java has some issues related to date types.
The first one is that in the typeMapping it defines Date as java.time.LocalDate which is correct.
But then in importMapping it defines Date as java.time.LocalDate which is incorrect and doesn't match with the typeMapping
It should define Date as java.time.LocalDate in the typeMapping.
The second one is that it defines DateTime as java.time.LocalDateTime in the typeMapping and in the importMapping, which is wrong, it should be java.time.OffsetDateTime.
This can cause bugs because the servers and the clients can (and most probably are) in different timezones.
This is already fixed in KotlinSpringServerCodegen and KotlinClientCodegen but not in AbstractKotlinCodegen.
Finally since java.util.Date is never used, it's not necessary in the Kotlin Client Serializer, so it's removed.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master,5.1.x,6.0.x -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@jimschubert (2017/09)