Skip to content
GitLab

[PHP] Add gitignore to AbstractPhpCodegen

Merged Administrator requested to merge github/fork/ybelenko/php_gitignore into master

Created by: ybelenko

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

After conversation with @ackintosh we've agreed that we need to remove PHP related rules from root .gitignore. All PHP codegens should produce own .gitignore by default.

What I did:

  1. Added .gitignore to supportingFiles in AbstractPhpCodegen
  2. Grabbed minimal .gitignore for each PHP codegen from this repo
  3. Noticed broken path in Silex security script. Check 27fb8ba2
  4. Added few rules from root .gitignore to local Symfony .gitignore. Check a20e201d

About composer.lock. I think, it does make sense to commit composer.lock in server implementations and do opposite in client SDK.

This PR is big and serious, so I can wait while all PHP codegens will be properly checked.

cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh