Skip to content
GitLab

[jaxrs-spec] setup test for samples, repair import and dependency

Merged Administrator requested to merge github/fork/fujigon/feature/jaxrs-spec-should-be-tested into master

Created by: fujigon

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @wing328

Description of the PR

This patch fixes https://github.com/OpenAPITools/openapi-generator/issues/726

Changes

  • add pom.xml settings of the project so that generated samples of jaxrs-spec, jaxrs-spec-interface and jaxrs-spec-interface-response are tested
  • fix template to generate correct import
  • fix dependency settings in pom.xml of samples
  • re-generate samples

Disscussion

multipart/form-data related

https://github.com/OpenAPITools/openapi-generator/commit/f8691ed21f4174e1a5e5de5e1de515765f98782d I googled multipart/form-data related annotation for pure jax-rs, but I came to the conclusion that there'is no suitable one. (So, jersey, apache-cxf and rest-easy define their own annotation to support multipart/form-data).

So, in jaxrs-spec, I deleted the Attachment fileDetail field from the template. Is this fix OK?

Note

Last commit https://github.com/OpenAPITools/openapi-generator/commit/dc5b9e096df2f8e8c7f5ad75a2dd832ed28d867c includes only sample re-generation by ./bin/jaxrs-spec-petstore-server*.