Skip to content
GitLab

Parameter enhancement in PathItem

Merged Administrator requested to merge github/fork/jmini/issue630_fix_param_in_pathItem into master

Created by: jmini

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.2.x, 4.0.x. Default: master.
  • Copied the technical committee: @OpenAPITools/generator-core-team

Description of the PR

Fixes #630 (closed).

The problem was that PathItem parameters were only added to Operation parameter only if operation.getParameters() != null. This condition is wrong. I have removed it.

I have also used operation.addParametersItem(parameter); instead of operation.getParameters().add(parameter); because the first version also works when the parameters list in operation is null.