Skip to content
GitLab

[WIP][Golang][client] fix enum constant collisions, Fix #535

Closed Administrator requested to merge github/fork/grokify/go/client/fix/enum-constant-collisions into 4.0.x

Created by: grokify

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@antihax @bvwells

Description of the PR

fix https://github.com/OpenAPITools/openapi-generator/issues/535

This is filed against the 4.0.x branch because this is a braking change without fallback. Constants will have new names with a class prefix.

go-swagger also prefixes constants with the class name but creates the base name differently.

While this PR fixes the immediate issue of #535, open issues / possible enhancements include:

  • consistent formatting
  • avoiding collisions between abc, -abc, _abc, etc.