Skip to content
GitLab

ModelUtils: isMap only if additionalProperties is a Schema

Merged Administrator requested to merge github/fork/jmini/issue409_fix_additionalproperties_false into master

Created by: jmini

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee: @OpenAPITools/generator-core-team

Description of the PR

Fix for issue #409 (closed). The ClassCastException is no longer present (see Unit Test)

More details:

As discussed in #409 (closed) getAdditionalProperties() can return a Boolean or a Schema.

  • When Schema: Map case as already implemented
  • When Boolean: (out of scope for this PR)
    • true => for Free-Form Objects"
    • false => can be ignored, default value (to be verified)