Created by: janjongboom
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first. -
Filed the PR against the correct branch: master,4.1.x,5.0.x. Default:master. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @nicokoenig @topce @akehir
Description of the PR
When compiling an API generated using the typescript-jquery generator against Typescript 3.6.2 in strict mode there are a number of issues with the generated code.
-
defaultExtraJQueryAjaxSettingsis of typeJQueryAjaxSettings | undefinedbut is set tonull(valid in normal mode, not valid in strict mode). - In
extendObjhasOwnPropertyis called onobjB. ButobjBis not guaranteed to be an object as it inherits from unknown typeT1. - Properties in the
Configurationclass are marked asstring, but have no initializer, thus giving false safety when consuming this class (values could be undefined too).
This PR adds some small guards around these issues.