Skip to content
GitLab

[Slim] Upgrade API server integration tests to use Fake Petstore spec

Merged Administrator requested to merge github/fork/ybelenko/slim_fake_petstore into master

Created by: ybelenko

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  1. Old Petstore spec swapped with Fake Petstore spec.
  2. postProcessOperations method overriden. Special value / properly escaped to avoid php syntax errors.
  3. Add own private static final LOGGER like in #26
  4. toModelName copied from PHPClient codegen which is much more enhanced at that point.
  5. postProcessSupportingFileData method overriden. Sort action fixes static route shadowing #7698, but it sorts operations only within tag. It means that if user place path appointmens/{id} in first api group(tag Appointmets for example) and appointments/me path in last group(tag MyResources), this sort function will produce broken stubs anyway.
  6. Main mustache template slightly improved to suppress most of notices and warnings.

I've checked all endpoints with petstore-with-fake-endpoints-models-for-testing.yaml from Swagger UI and most of responses are correct with only few exceptions. I will add failed endpoints description in few days.

cc @jfastnacht