Skip to content
GitLab

[go] fix multipart for non-file inputs

Merged Administrator requested to merge github/fork/thiagoarrais/go-multipart-boundary into master

Created by: thiagoarrais

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This changes go clients to append the multipart boundary parameter to the content type header independent of file content being present. This fixes #2772 (closed), which is an issue with pure multipart formdata.

Questions for maintainers

  1. I've ran ./bin/go-petstoresh and updated the sample client. I'm not sure if I need ro run ./bin/go-petstore-withxml.sh too?

  2. How should I go about adding tests for this?

cc @antihax @bvwells @grokify @kemokemo