Skip to content
GitLab

Fix ServiceLoader initialization

Merged Administrator requested to merge github/fork/adigerber/fix-classloader-in-serviceloaders into master

Created by: adigerber

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR fixes the service loader initializations for CodegenConfig so that the correct class loader is used, regardless of the thread's context class loader.

This essentially fixes an issue that occurs when calling CodegenConfigurator.toClientOptInput from a thread that doesn't use the same class loader which is used to load openapi-generator module (e.g. build tool plugins), and as a result, generator names cannot be specified.

There's still an issue with code generation itself but that is related to the swagger-parser module; I'll file another PR there to fix that as well.