Skip to content
GitLab

[haskell-http-client] compare rendered form in PropMime

Closed Administrator requested to merge github/fork/guoshimin/propmime into master

Created by: guoshimin

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

It is known that fromJson and toJson for Maybe are not the inverse of each other: https://github.com/bos/aeson/issues/376. It causes failures in the PropMime tests.

> encode (Just Null)
"null"
> encode (Nothing :: Maybe Value)
"null"
> > decode "null" :: Maybe Value
Just Null

Changing the PropMime tests to compared the rendered form instead.

@jonschoning, what do you think?