Skip to content
GitLab

Apply `GIN_MODE=release` for the Dockerfile of `go-gin-server`

Merged Administrator requested to merge github/fork/kemokemo/apply_gin_mode into master

Created by: kemokemo

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

In order to run as Release mode, the gin-gonic/gin needs the environment variable GIN_MODE=release. I think that it is better for this environment variable to be applied to the Dockerfile generated by the go-gin-server generator.

@antihax (2017/11) @bvwells (2017/12) @grokify (2018/07) Would you please review this PR? Thank you so much! 😃