Skip to content
GitLab

[Dart] query arguments of requests are now url encoded

Merged Administrator requested to merge github/fork/d3v-cl/dart_queryargs into master

Created by: d3v-cl

@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09)

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

The query arguments of requests are now url encoded. http://restserver/someAction?arg=a-gmail+address@gmail.com will now become: http://restserver/someAction?arg=a-gmail%2Baddress%40gmail.com

The + no longer becomes a space. Even worse previously a & inside an argument broke the request completely.