Skip to content
GitLab

[typescript] Add `importFileExtension` option to support ECMAScript module resolution

Merged Administrator requested to merge github/fork/danmichaelo/ts-esm into master

Created by: danmichaelo

Node.js ECMAScript module resolution requires file extensions for relative imports. Typescript also conforms to this requirement when using the new nodenext module resolution setting.

File extension support was already added to the Typescript(experimental) generator for Deno in #6732. The current PR generalizes the extensionForDeno parameter into importFileExtension and makes it user configurable, so users can set it to .js for a pure ESM package or .mjs for a dual package.

The current PR only adds the option to TypeScriptClientCodegen, which seems to be the new generator if I understand it right, but if the PR is accepted, I'd like to try adding it to AbstractTypeScriptClientCodegen as well in a separate PR, to support typescript-fetch and friends.

fixes #14333 (closed)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka