Created by: TORISOUP
What is the issue
- When a timeout occurs due to Configuration.Timeout, a TaskCanceledException is thrown, but this can not distinguish upstream whether it is a manual cancellation or a timeout.
Correction details
Changed to TimeoutException is thrown when a timeout occurs due to configuration.Timeout.
How to validate the work
- Set an extremely small value (e.g., 1 ms) in configuration.Timeout and execute the communication in production.
- At this time, check that a TimeoutException is thrown and the process is aborted.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master(6.1.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@mandrean @shibayan @Blackclaws @lucamazzanti