Skip to content
GitLab

[python-experimental] simplifies type checking

Merged Administrator requested to merge github/fork/spacether/python_exp_simplify_type_checking into master

Created by: spacether

[python-experimental] simplifies type checking type info is stored in

  • SchemaTypeCheckerClsFactory
  • base mixins like StrMixin classes

Rather than storing that info in multiple locations, it is better to store it one place, and have a class use that info to check types.

This PR:

  • stores types in mixins like StrBase._types
  • moves schema type checking into the Schema class, SchemaTypeCheckerClsFactory removed

Note: format info is stored in base classes like Int32Base, not in MetaOapg type information is stored in mixin classes like StrMixin, not in MetaOapg

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.