Created by: ityuhui
Hi @wing328 @zhemant @michelealbano
When a field of a JSON map is null, e.g. in below example, annotations of metadata is null
{
"apiVersion": "v1",
"kind": "ServiceAccount",
"metadata": {
"name": "test-sa",
"namespace": "smoking-test",
"annotations": null
}
}
*_parseFromJSON will treat annotations as invalid/error, and free the total memory of metadata
The detail is at https://github.com/kubernetes-client/c/issues/138
This PR treats "null" as a valid value for a field of a JSON map.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master(6.1.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.