Skip to content
GitLab

Fix javascript-apollo generator/template

Merged Administrator requested to merge github/fork/joaomlneto/master into master

Created by: joaomlneto

Generated code does not compile with recent apollo-server versions. This PR attempts to make it generate compatible code with latest versions of the Apollo libraries.

Comments/reviews are highly desired! I do not fully understand the code, but my changes appear to fix compilation issues.

I'm submitting it to the master branch, but may be more appropriate to submit it to another branch?

Additionally, this may break compatibility with potential users using very old versions. What would be the best course of action to tackle this?

NodeJS/Javascript technical committee: @CodeNinjai @frol @cliffano

Closes #13190 (closed)

Todo list:

  • Bump Apollo Server compatibility to version 3
  • Fix tests
  • Fix parameters pased onto callApi — parameters contentTypes and accepts are missing.
  • https://github.com/apollographql/apollo-server/pull/1277 — make requestInit parameter available in every endpoint, passed onto callApi, subsequently passed onto the get/post/delete/patch/put methods on RESTDataSource.

Resources

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.