Skip to content
GitLab

Standardizes import gathering code

Merged Administrator requested to merge github/fork/spacether/feat_fixes_issue_12756 into master

Created by: spacether

Feat fixes issue #12756 (closed) Generates an additional 3.0.3 test in python-experimental that will now pass in CI Standardizes import gathering code That import gathering will be used if addSchemaImportsFromV3SpecLocations == true python-experimental sets it to true All other generators not impacted by this change (their imports remain as-is)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.