Merged
requested to merge github/fork/Laurens-W/allow_dynamic_influencing_of_inline_model_resolver into master
Created by: Laurens-W
Moving this logic so that a generator option that is processed in an overriden processOpts which is called in configureGeneratorProperties() can influence the useInlineModelResolver.
Should this logic be inside the configureGeneratorProperties method after processing opts but before pre processing the api? Or should it be in the generate method but after calling configureGeneratorProperties and configureOpenAPIInfo?
Merely opening this PR to have a discussion about this and which location for this logic would be preferable. @spacether The only reason it "works" in the Python generator is because the default is false @wing328
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master(6.1.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.