Skip to content
GitLab

#12490: Fix format 'date' serializing to day before desired date depending on the timezone/daylight-saving

Open Administrator requested to merge github/fork/stephanpelikan/bugfix/issue_12490 into master

Created by: stephanpelikan

Fix for https://github.com/OpenAPITools/openapi-generator/issues/12490.

Unfortunately, there is no test for "string, format=date" properties in samples/client/petstore/typescript-fetch which could ensure the change is not breaking anything. I tested the fix successfully using my project at which I discovered the bug:

apis.mustache: I added a request param 'xxx' and set it according to the issue description. The request was serialized like http://localhost:3000/api/v1/administration/member-onboarding/9fd4a12c-a879-469d-a602-0d78c6d62d54/take-over?xxx=2022-06-05

modelGeneric.mustache: This is the place where I discovered the error. Now the date is correct sent as birthdate: "2022-06-05" instead of 2022-06-04.

@leonyu: Please review and merge that PR.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.0.1) (patch release), 6.1.x (breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.