Created by: claudius-kienle
Desired Behaviour
The dart generator should only append the query parameter to the request if it is not required and nullable (like addressed in #8837). A possible openapi configuration snippet would be the following:
"/api/v1/specific_endpoint/": {
"get": {
"parameters": [
{
"in": "query",
"name": "specific_parameter",
"required": false,
"schema": {
"type": "integer",
"default": null,
"nullable": true
}
}
],Current Behaviour
The generator always adds the query parameter to the request map, even if it is nullable and not required.
Change
When investigating the respective template, I found that the generator would add the nullable check only, if the query parameter is not nullable. Therefore, I changed this so that the generator now adds the nullable check, if the query parameter is not required but nullable.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.