Skip to content
GitLab

[csharp] Use the provided 'sourceFolder' property to generate the test folder

Merged Administrator requested to merge github/fork/Starkie/csharp/fix-test-folder-inconsistency into 6.0.x

Created by: Starkie

Hi all!

This issue is regarding the csharp-netcore generator. There is a bit of an inconsistency in how the test folders are generated when the sourceFolder property is provided. For example:

  • Set the option sourceFolder to anything other than src.
    • In this case, I left it empty: --additional-properties=sourceFolder=""
  • Generate the client
  • See that the client was generated in the provided sourceFolder... but the tests where generated in src: image

In the AbstractCSharpCodegen.java, there is a TODO a few years old saying that a separate option for testFolder could be added: https://github.com/OpenAPITools/openapi-generator/blob/8551b0af492286a431c95ce3a37d7edf1ef4870a/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractCSharpCodegen.java#L73-L75

Until that is implemented, I created a little workaround, assigning the provided sourceFolder parameter to the testFolder.

With this change, the projects are generated as expected: image

Related issue: #1390

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    • @mandrean @frankyjuang @shibayan @Blackclaws @lucamazzanti